Add Xtensa va_arg assembly coverage#157108
Open
SergioGasquez wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? folkertdev |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
folkertdev
reviewed
May 29, 2026
| @@ -0,0 +1,130 @@ | |||
| //@ add-minicore | |||
| //@ assembly-output: emit-asm | |||
Contributor
There was a problem hiding this comment.
I believe you need that //@ min-llvm-version: 22 annotation here as well
| unsafe extern "C" fn read_f64(ap: &mut VaList<'_>) -> f64 { | ||
| // CHECK-LABEL: read_f64 | ||
| // | ||
| // XTENSA: l32i{{(\.n)?}} [[F64_NDX:a[0-9]+]], a2, 8 |
Contributor
There was a problem hiding this comment.
idk how you generate this exactly, I just copy things manually from the .s file that pops up in the error message. Not great, but then it should work and be a bit more readable. I wouldn't expect the code to change much.
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Xtensa va_arg assembly coverage, see #156568